Skip to content

crypto: runtime deprecate hmac constructor#52071

Merged
nodejs-github-bot merged 1 commit into
mainfrom
runtime-deprecate-hmac-constructor
Mar 20, 2024
Merged

crypto: runtime deprecate hmac constructor#52071
nodejs-github-bot merged 1 commit into
mainfrom
runtime-deprecate-hmac-constructor

Conversation

@marco-ippolito

Copy link
Copy Markdown
Member

part 2 of: #51881

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Mar 13, 2024
@marco-ippolito marco-ippolito force-pushed the runtime-deprecate-hmac-constructor branch from cb97adb to 2129617 Compare March 13, 2024 11:04
@marco-ippolito marco-ippolito added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 13, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@ShogunPanda ShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 20, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 20, 2024
@nodejs-github-bot nodejs-github-bot merged commit d62ab3a into main Mar 20, 2024
@nodejs-github-bot nodejs-github-bot deleted the runtime-deprecate-hmac-constructor branch March 20, 2024 16:20
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in d62ab3a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crypto Issues and PRs related to the crypto subsystem. deprecations Issues and PRs related to deprecations. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants